graph: backend: passes: verbose log enhancement #2320
Conversation
|
make test |
| @@ -45,12 +49,15 @@ status_t compile_ops(std::shared_ptr<subgraph_t> &sg) { | |||
| = op_schema_registry_t::get_op_schema(op->get_kind()); | |||
| if (!opm) { | |||
| assertm(false, "no schema for current op"); | |||
There was a problem hiding this comment.
Do we have to keep the assertm after enriching the verbose? If not, maybe we can fuse the if condition check into the macro.
There was a problem hiding this comment.
assertm will abort in debug mode, verbose check only print one log. I think they have different debug scenarios. So I just keep the asserm.
There was a problem hiding this comment.
I also feel the assertions are less useful now after verbose logs are added.
There was a problem hiding this comment.
just removed assertm and wrapped the condition check into VCHECK. Thank you all.
| #define VCHECK_MEMORY_PLANNING(cond, status, msg, ...) \ | ||
| VCONDCHECK(graph, create, check, memory_planning, (cond), status, msg, \ | ||
| ##__VA_ARGS__); | ||
|
|
||
| namespace dnnl { |
There was a problem hiding this comment.
random place: do we also need to add check here on L351
| per_channel_broadcast)) { | ||
| return status::invalid_shape; | ||
| } | ||
| VCHECK_INSERT_OPS(prelu_doable(ltw(src_lt).vdims(), ltw(wei_lt).vdims(), |
There was a problem hiding this comment.
I suggest to put prelu_doable() into a separate line and pass its return value to VCHECK_INSERT_OPS. It will make the code easier to read and debug.
There was a problem hiding this comment.
changed as suggested. please take a look again. thanks
| @@ -45,12 +49,15 @@ status_t compile_ops(std::shared_ptr<subgraph_t> &sg) { | |||
| = op_schema_registry_t::get_op_schema(op->get_kind()); | |||
| if (!opm) { | |||
| assertm(false, "no schema for current op"); | |||
There was a problem hiding this comment.
I also feel the assertions are less useful now after verbose logs are added.
rongzha1
force-pushed
the
rzhang/verbose_passes
branch
from
bb374d9 to
157df77
Compare
|
make test |
verbose log enhancement for compile passes